Skip to content

[Sofa.Type] Fix compile-time Mat and Vec #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damienmarchal merged 3 commits into from
Sep 21, 2022
Merged

[Sofa.Type] Fix compile-time Mat and Vec #3281

damienmarchal merged 3 commits into from
Sep 21, 2022

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Sep 8, 2022 •
edited
Loading

  • std::abs is constexpr only in c++23
    -> as stated in the standard... But gcc flagged it constexpr 🤫

  • std::sqrt is not constexpr at all. Implementations exists though. For now, all functions relying on sqrt is not constexpr (norm methods)

Allows to compile alxbilger/SofaBenchmark#27 (for mac and msvc then)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Sep 8, 2022
@fredroy
Copy link
Contributor Author

fredroy commented Sep 8, 2022

[ci-build][with-all-tests]

alxbilger
alxbilger reviewed Sep 8, 2022
View reviewed changes
@fredroy
Copy link
Contributor Author

fredroy commented Sep 17, 2022

[ci-build][with-all-tests]

1 similar comment
@alxbilger
Copy link
Contributor

alxbilger commented Sep 21, 2022

[ci-build][with-all-tests]

@damienmarchal
Copy link
Contributor

damienmarchal commented Sep 21, 2022

Merge if CI pass.

@damienmarchal damienmarchal added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 21, 2022
@damienmarchal damienmarchal merged commit f3a4926 into sofa-framework:master Sep 21, 2022
@fredroy fredroy deleted the fix_constexpr_type branch October 13, 2022 05:59
@hugtalbot hugtalbot added this to the v22.12 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxbilger alxbilger alxbilger left review comments

Assignees

No one assigned

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

v22.12

Development

Successfully merging this pull request may close these issues.

4 participants

@fredroy @alxbilger @damienmarchal @hugtalbot